Created attachment 236141 [details] Update to v1.9.4
QA portlint -AC: OK poudriere testport on 13.1/amd64: OK
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=efa005214e4254e1b2ee468c09009c71d5622e33 commit efa005214e4254e1b2ee468c09009c71d5622e33 Author: Martin Waschbusch <martin@waschbuesch.de> AuthorDate: 2022-08-27 10:49:53 +0000 Commit: Po-Chuan Hsieh <sunpoet@FreeBSD.org> CommitDate: 2022-08-27 10:50:04 +0000 archivers/liblz4: Update to 1.9.4 Changes: https://github.com/lz4/lz4/releases PR: 266063 archivers/liblz4/Makefile | 6 +++--- archivers/liblz4/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)
Hi, It would've been nice if we could've waited on https://github.com/lz4/lz4/pull/1139 to land so unit tests works as expected. Best regards, Daniel
(In reply to Daniel Engberg from comment #3) Noted. I'll try to keep an eye on that. Should this not warrant a version bump from upstream's point of view, I may include the pull and update the port revision. If it does, an update will happen anyway. Is that a reasonable approach?
Bump PORTREVISION as it does touch some things in the build process too. Sounds fine otherwise, thanks!
It has now landed https://github.com/lz4/lz4/commit/214bfb325bd4db112b73859912b919aa35e12d61
(In reply to Daniel Engberg from comment #6) Thanks. I followed that GH issue. Question: Is it safe to use the state of affairs (in the dev branch) as of the commit you referenced? Or would the right approach be to stay with https://github.com/lz4/lz4/releases/tag/v1.9.4 and cherry-pick the commits relating to testing / meson?
(In reply to Martin Waschbüsch from comment #7) Cherry-pick, if it piles up a lot I guess we should wait until next release to fix tests etc.
(In reply to Daniel Engberg from comment #8) See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267667 Tests build, but one of the tests fails. Any help with that is appreciated.