Bug 266415 - dns/ddclient: Update to v3.10 RC2
Summary: dns/ddclient: Update to v3.10 RC2
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks: 267323
  Show dependency treegraph
 
Reported: 2022-09-14 16:45 UTC by David Schlachter
Modified: 2023-02-02 07:39 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (mjl)


Attachments
Patch to update ddclient to v3.10 RC2 (9.84 KB, patch)
2022-09-14 16:45 UTC, David Schlachter
no flags Details | Diff
Patch for ddclient (9.12 KB, patch)
2022-09-15 19:44 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Schlachter 2022-09-14 16:45:17 UTC
Created attachment 236556 [details]
Patch to update ddclient to v3.10 RC2

Since v3.9.1 of ddclient was released two years ago, two release candidates for v3.10 have been released. These include many bug fixes and support for new providers (see release notes: https://github.com/ddclient/ddclient/releases).

The attached patch updates the ddclient port to the latest release candidate from May of this year. Notable changes to the port:

- updated PORTVERSION to fit ports conventions for pre-releases (3.10.0.p2)
- updated dependencies (removed p5-Data-Validate-IP, added p5-JSON-PP)
- ddclient is no longer distributed as a simple script, rather, it's built with automake (GNU_CONFIGURE=yes)
- at some point, the project moved the default install path from /sbin to /bin (e.g. see https://github.com/ddclient/ddclient/commit/6b7800380c7f5ab8168e900dbb48f5e46936ebb6) I updated the port to use /bin, but could update it to stay in /sbin on FreeBSD if that makes sense
- I've kept the patches but removed sections that don't make sense anymore (e.g. paths are now set with configure rather than being hard-coded, fetch logic has changed and doesn't need path to certs, etc)

Please let me know if there's anything that needs to be changed before this could be merged.
Comment 1 Daniel Engberg freebsd_committer 2022-09-15 19:44:42 UTC
Created attachment 236575 [details]
Patch for ddclient

Some minor fixups

Remove USES= tar:bzip2
Fix pkg-list
Use direct paths rather than using cd command
Comment 2 Fernando Apesteguía freebsd_committer 2022-10-06 06:02:54 UTC
diizzy@, are you taking this?
Comment 3 Daniel Engberg freebsd_committer 2022-10-06 19:52:39 UTC
Still waiting on feedback from either one
Comment 4 Fernando Apesteguía freebsd_committer 2022-10-07 05:38:05 UTC
(In reply to Daniel Engberg from comment #3)
You can call feedback timeout. It's been more than 2 weeks.
Comment 5 mjl 2022-10-09 06:30:41 UTC
I (maintainer) tried Daniel's patch.  I am not 100% sure that it works.  The first time I ran it I got:

FAILED:   updating [redacted]: unexpected status (14)
Use of uninitialized value $h in hash element at /usr/local/bin/ddclient line 4080.
Use of uninitialized value $_[0] in sprintf at /usr/local/bin/ddclient line 2139.
WARNING:  updating : nochg: No update required; unnecessary attempts to change to the current address are considered abusive
Use of uninitialized value $h in hash element at /usr/local/bin/ddclient line 4089.
Use of uninitialized value $h in hash element at /usr/local/bin/ddclient line 4090.
Use of uninitialized value $h in hash element at /usr/local/bin/ddclient line 4091.
Use of uninitialized value $h in hash element at /usr/local/bin/ddclient line 4080.
Use of uninitialized value $_[0] in sprintf at /usr/local/bin/ddclient line 2139.
FAILED:   updating : unexpected status (0)
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.
Use of uninitialized value in string ne at /usr/local/bin/ddclient line 1133.

Second time:

WARNING:  skipping update of [redacted] from <nothing> to 118.93.169.166.
WARNING:  last updated <never> but last attempt on Sun Oct  9 19:19:31 2022 failed.
WARNING:  Wait at least 5 minutes between update attempts.

And via email 5 minutes later:

FAILED:   updating [redacted]: unexpected status (14)
WARNING:  updating : nochg: No update required; unnecessary attempts to change to the current address are considered abusive
FAILED:   updating : unexpected status (0)
FAILED:    was not updated because protocol <undefined> is not supported.

So I'm not sure that it works.  my dyndns updated two days prior to this.  @David: comments?