Bug 275432 - net/mpifx: upgrade to a recent commit in order to support MPICH-4.x
Summary: net/mpifx: upgrade to a recent commit in order to support MPICH-4.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL: https://github.com/dftbplus/mpifx/iss...
Keywords:
Depends on: 275431
Blocks: 275317
  Show dependency tree / graph
 
Reported: 2023-11-29 17:48 UTC by Thierry Thomas
Modified: 2023-12-10 10:24 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Upgrade to a recent commit in order to support MPICH-4.x (1.62 KB, patch)
2023-11-29 17:48 UTC, Thierry Thomas 		no flags Details | Diff
Upgrade to a recent commit in order to support MPICH-4.x (rev.2) (834 bytes, patch)
2023-12-06 00:57 UTC, Yuri Victorovich 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2023-11-29 17:48:53 UTC 
Created attachment 246668 [details]
Upgrade to a recent commit in order to support MPICH-4.x

mpifx does not build with MPICH-4.x: see <https://github.com/dftbplus/mpifx/issues/48>.

A fix for this issue has been committed, but nothing has been released yet: meanwhile I propose the attached patch to a recent tag in order to fix the error.

Remark: this fix requires mpi_f08.mod, to be installed by MPICH.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2023-12-05 21:02:32 UTC 
The build fails for me:

> --- lib/CMakeFiles/mpifx.dir/mpifx_win.f90.o ---
> /wrkdirs/usr/ports/net/mpifx/work/.build/lib/mpifx_win.f90:4:7:
> 
>     4 |   use mpi_f08
>       |       1
> Fatal Error: Cannot open module file 'mpi_f08.mod' for reading at (1): No such file or directory
> compilation terminated.
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2023-12-05 21:16:49 UTC 
(In reply to Yuri Victorovich from comment #1)

This file is installed by MPICH-4 (my latest patch in PR 275317), when it is built by 12.2.0-7 (i.e. after dd37ac872d51).

When MPICH does not find ISO_Fortran_binding.h it does not build this module.
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2023-12-06 00:57:17 UTC 
Created attachment 246812 [details]
Upgrade to a recent commit in order to support MPICH-4.x (rev.2)

I see.

I've attached the equivalent patch that handles the GitHub revision as a sub-version.

Please commit it when you are ready.


Thanks,
Yuri
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2023-12-10 10:23:26 UTC 
Committed, thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2023-12-10 10:24:17 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=73c6d8942b4be132644c669f5970a9b856dcee48

commit 73c6d8942b4be132644c669f5970a9b856dcee48
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2023-12-10 10:04:08 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2023-12-10 10:23:11 +0000

    net/mpifx: upgrade to a recent commit in order to support MPICH-4.x

    mpifx does not build with MPICH-4.x:
    see <https://github.com/dftbplus/mpifx/issues/48>.

    A fix for this issue has been committed, but nothing has been released yet:
    meanwhile I propose the attached patch to a recent tag in order to fix the
    error.

    Remark: this fix requires mpi_f08.mod, to be installed by MPICH.

    PR:             275432
    Approved by:    yuri@ 'maintainer)

 net/mpifx/Makefile | 3 ++-
 net/mpifx/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)