Created attachment 249079 [details] Update to 2.6.0 Update to 2.6.0 - Add DOXYGEN, and EXAMPLE options - Use upstream name for ${PORTNAME} https://github.com/SFML/CSFML/releases/tag/2.6.0 poudriere-testport: > 13.2-{amd64,i386}-release: OK > 14.0-{amd64,i386}-release: OK > main-{amd64,i386}: OK
Hi! Can you fix this patch? I applied the patch on the bug 277643, but, the build failed. ===> CSFML-2.6.0 depends on package: SFML>0 - not found ===> CSFML-2.6.0 depends on package: SFML>0 - not found *** Error code 1 I fixed this error changing the LIB_DEPENDS to: -BUILD_DEPENDS= sfml>0:devel/sfml -LIB_DEPENDS= libsfml-audio.so:devel/sfml \ - libsfml-graphics.so:devel/sfml \ - libsfml-network.so:devel/sfml \ - libsfml-system.so:devel/sfml \ - libsfml-window.so:devel/sfml +BUILD_DEPENDS= SFML>0:devel/asfml +LIB_DEPENDS= libasfml-audio.so:devel/asfml \ + libasfml-graphics.so:devel/asfml \ + libasfml-network.so:devel/asfml \ + libasfml-system.so:devel/asfml \ + libasfml-window.so:devel/asfml Does this make sense to you?
(In reply to Gabriel M. Dutra from comment #2) Hello, I fixed this error changing the LIB_DEPENDS to: > -BUILD_DEPENDS= sfml>0:devel/sfml The uploaded patch already has: > +BUILD_DEPENDS= SFML>0:devel/sfml > -LIB_DEPENDS= libsfml-audio.so:devel/sfml \ > - libsfml-graphics.so:devel/sfml \ > - libsfml-network.so:devel/sfml \ > - libsfml-system.so:devel/sfml \ > - libsfml-window.so:devel/sfml [...] > +LIB_DEPENDS= libasfml-audio.so:devel/asfml \ > + libasfml-graphics.so:devel/asfml \ > + libasfml-network.so:devel/asfml \ > + libasfml-system.so:devel/asfml \ > + libasfml-window.so:devel/asfml This currently does not make sense to me (incidentally, neither does the world, or any of it's composition), asfml depends on csfml, which depends on sfml. I am retesting the patch, and going to bed, I will report back later. Thanks.
(In reply to Gabriel M. Dutra from comment #2) Hey Gabriel, I am not able to reproduce the build failure. I have checked out latest and clean Ports tree, and applied the patch, build passed. I used git apply, found not problems, started again and tried patch < /var/tmp/${foo}, the build also passed. I do not know how the patched devel/csfml Port could have: > BUILD_DEPENDS= sfml>0:devel/sfml instead of BUILD_DEPENDS= SFML>0:devel/asfml Thanks.
Hi, The build had many errors, see: CMake Error at src/SFML/CMakeLists.txt:24 (find_package): Could not find a configuration file for package "SFML" that is compatible with requested version "2.6". The following configuration files were considered but not accepted: /usr/local/lib/cmake/SFML/SFMLConfig.cmake, version: 2.5.1 -- Configuring incomplete, errors occurred! *** Error code 1 ----------- The controllable properties are listed in the section "Controlling FreeType Modules" in the reference's table of contents (/usr/local/share/doc/freetype2/reference/index.html, if documentation was installed). ===> CSFML-2.6.0 depends on package: SFML>0 - not found *** Error code 1
PR requires updates to SFML
(In reply to Gabriel M. Dutra from comment #5) > The build had many errors, see: > > CMake Error at src/SFML/CMakeLists.txt:24 (find_package): > Could not find a configuration file for package "SFML" that is compatible > with requested version "2.6". > > The following configuration files were considered but not accepted: > > /usr/local/lib/cmake/SFML/SFMLConfig.cmake, version: 2.5.1 > > > > -- Configuring incomplete, errors occurred! > *** Error code 1 Is SFML-2.6.x installed. From the log fragment, it looks like SFML-2.5.x is still installed?
Comment on attachment 249079 [details] Update to 2.6.0 Patch is obsoleted by 2.6.1 release.
Update to 2.6.1 was committed already: https://cgit.freebsd.org/ports/commit/?id=7125faf26f5bfbd3c0401987a55b3d80436bda95
CSFML ≠ SFML
Bwaah... I was baited by devel/csfml/Makefile being the first file modified in the patch... My bad - apologies!
(In reply to Joel Bodenmann from comment #11) All good, it tripped me too, and required a number of double takes.
Paychecks and hardware are slowly trickling in, so I hopefully will be able to return to my duties soon.
(In reply to Alastair Hogge from comment #8) Your patch doesn't apply! Could you please check it? Why do you want change PORTNAME?
(In reply to Zsolt Udvari from comment #14) There is no patch for 2.6.1 yet, as per my explanation to you in bug #276210, comment #10. As for the name change (going by the previous patch, which I no longer mark as maintainer approved), upstream uses it, and allows removal of: > GH_PROJECT= ${PORTNAME:tu} from the Makefile.
Comment on attachment 249079 [details] Update to 2.6.0 This patch seems to be causing more confusion than it is worth the time.
(In reply to Zsolt Udvari from comment #14) > Why do you want change PORTNAME? The reason for this is also explained in the obsoleted patch comment, and comment #1 of this bug report.
(In reply to Alastair Hogge from comment #17) There are only some ports which contain uppercase letters - but not every letter! See the "Table 2.Package Naming Examples" (https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkgname), third row: EmiClock -> emiclock (No uppercase names for single programs).
(In reply to Zsolt Udvari from comment #18) OK, fair enuf. So the next patch will restore the lowercase name of the distribution name. Thanks for clearing that up.