libknot connects to knot dns through socket and needs libknot.so to run.

I added a LIB_DEPENDS= libknot.so:dns/knot3

Please await my alternative proposal (I'm currently testing)

Created attachment 249910 [details]
the whole picture, adjusting dns/knot3, adding dns/py-libknot

(In reply to Einar Bjarni Halldórsson from comment #1)

NO_ARCH=        yes

should be below

USE_PYTHON=    autoplist concurrent distutils pep517

distutils i.c.w. pep517 is conflicting.
distutils w/o pep517 works.
pep517 is likely preferred, but fails building, unless you add devel/py-hatchling as build dependancy.

I was trying to make this a metaport, as that would prevent version conflicts and double work. But it would make the Makefile of dns/knot3 even more overcomplicated. So instead I would like to take the approach as in attached patch.

All mutations now validate perfectly with all the testing tools.

(In reply to Leo Vandewoestijne from comment #3)
LGTM

Created attachment 249934 [details]
final dns/py-libknot

Final result.

Thanks Einar, for pointing out I missed this module.

Created attachment 249976 [details]
final dns/py-libknot - tabs are tabs

Identical, but corrected: retained tabs as tabs (and not spaces).

Created attachment 251568 [details]
dns/py-libknot 3.3.6

Adjustment to make it the current 3.3.6

(In reply to Leo Vandewoestijne from comment #7)
Patch already tested succesfully in Poudriere,
but also now when having the current Knot 3.3.6 already in place.

Created attachment 251690 [details]
py-libknot 3.3.7

same, but update to Knot 3.3.7

Comment on attachment 249864 [details]
Adds new port, dns/py-libknot

Declined 3.3.5 patch - for clarity.

The 3.3.7 patch is ready to be commited.

Created attachment 252240 [details]
py-libknot 3.3.8

Same, but update to Knot 3.3.8

Tested all fine using poudriere, for all production versions.
Ready to be commited.

Comment 12 Vladimir Druzenko 2024-07-23 13:13:25 UTC

(In reply to Leo Vandewoestijne from comment #11)
WWW is weird:
dns/py-libknot/Makefile:WWW=             https://gitlab.nic.cz/knot/knot-dns/-/tree/master/python/libknot

Why not like for other knot ports:
dns/knot-resolver/Makefile:WWW=          https://www.knot-resolver.cz/
dns/knot3/Makefile:WWW=          https://www.knot-dns.cz/

(In reply to Vladimir Druzenko from comment #12)
> Why not like for other knot ports?
>
I thought it was useful to point straight to the corresponding documentation specifically for this lib, especially since the generic knot3 documentation doesn't include it.

Comment 14 commit-hook 2024-07-23 16:52:39 UTC

A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1a18e0ae75e73291bb9e6f9ed1ca832ae3e09daa

commit 1a18e0ae75e73291bb9e6f9ed1ca832ae3e09daa
Author:     Leo Vandewoestijne <freebsd@dns.company>
AuthorDate: 2024-07-23 16:49:21 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-23 16:49:21 +0000

    dns/py-libknot: new port: Python API using knot.sock to interact with the Knot DNS daemon

    Using this module it's possible to create scripts for efficient tasks
    that would require complex shell scripts with multiple calls of knotc.
    For communication with the daemon it uses the same mechanism as the
    knotc utility, i.e. communication via a Unix socket.

    PR:     278280

 dns/Makefile                   |  1 +
 dns/py-libknot/Makefile (new)  | 22 ++++++++++++++++++++++
 dns/py-libknot/distinfo (new)  |  3 +++
 dns/py-libknot/pkg-descr (new) |  2 ++
 4 files changed, 28 insertions(+)

Comment 15 Vladimir Druzenko 2024-07-23 16:58:55 UTC

Thanks.