Created attachment 251533 [details] knot version Last version of Knot was released. These two patches will update accordingly. Due to the new (staged) file I was unable to create a single patch. But when applied it all goes well in poudriere (AMD, 13.2 13.3 and 14.0).
Created attachment 251534 [details] knot update
Created attachment 251539 [details] knot update - minus CURDIR Minor adjustment, modified: include "${.CURDIR}/knotdns.mk" to include "knotdns.mk" such that metaport dns/knot3-lib would also be able to find and read it.
Hi Leo, Why use an external variable for the version of the port?
(In reply to Fernando Apesteguía from comment #3) Such that the new port dns/py-libknot wont require (m)any maintenance, once also DISTINFO_FILE= would be added there. It then always will be automaticly in sync with new releases.
Minor correction on my reply, that 'DISTINFO_FILE=' was impossible since that has it's own source, which is the same reason I couldn't make dns/py-libknot a metaport. But the essence remains; to have them in sync.
Are the two currently approved patches to be applied? Or only the last one?
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b4a7459e765acd411f6bf56455a7b7b837434cee commit b4a7459e765acd411f6bf56455a7b7b837434cee Author: Leo Vandewoestijne <freebsd@dns.company> AuthorDate: 2024-06-21 07:23:31 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-06-21 16:17:48 +0000 dns/knot3: upgrade to 3.3.6 Externalization of the port version to help keeping in sync with the upcoming port dns/py-libknot to be introduced in PR #278280. ChangeLog: https://www.knot-dns.cz/2024-06-12-version-336.html Features: * knotd: configurable control socket backlog size (see 'control.backlog') * knotd: optional configuration of congruency of generated keytags (see 'policy.keytag-modulo') * knotc: support for exporting configuration schema in JSON (see 'conf-export') * mod-dnstap: configuration of sink allows TCP address specification Improvements: * knotd: last-signed serial is stored to KASP even if not a secondary zone * knotd: allowed catalog role member in a catalog template configuration * knotd: some references in a zone configuration can be set empty to override a template * knotd: allowed zone backup during a zone transaction * knotd: add remote TSIG key name to outgoing event logs * knotc: zone backup with '+keysonly' silently uses all defaults as 'off' * kxdpgun: host name can be used for target specification * libs: upgraded embedded libngtcp2 to 1.5.0 * doc: various fixes and updates Bugfixes: * knotd: reset TCP connection not removed from a connection pool * knotd: server wrongly tries to remove removed ZONEMD * knotd: failed to parse empty list from a textual configuration * knotd: blocking zone signing in combination with an open transaction causes a deadlock * knotd: missing RCU lock when sending NOTIFY * kdig: QNAME letter case isn't preserved if IDN is enabled * kdig: failed to parse empty QNAME (do not fill question section) * kxdpgun: floating point exception on SIGUSR1 #927 * libknot: incorrect handling of regular QUIC tokens in incoming initials * python: failed to set an empty configuration value PR: 279828 dns/knot3/Makefile | 3 ++- dns/knot3/distinfo | 6 +++--- dns/knot3/files/knot.in | 3 ++- dns/knot3/files/pkg-message.in | 2 +- dns/knot3/knotdns.mk (new) | 1 + 5 files changed, 9 insertions(+), 6 deletions(-)
(In reply to Fernando Apesteguía from comment #6) Yes, correct, both; I searched long, but was unable to find the correct `git diff` syntax to get AND diffs AND new files in a single patch.
Thanks!