The link[1] in the description of "needs-staging" in the Bugzilla keywords list[3] to is broken as it was recently renamed[2]. [1]: https://wiki.freebsd.org/ports/StageDir [2]: https://wiki.freebsd.org/Ports/StageDir [3]: https://bugs.freebsd.org/bugzilla/describekeywords.cgi
(In reply to Mateusz Piotrowski from comment #0) I've worked around it on the wiki side by using a page redirect. (I learned something new today.)
The needs-staging keyword is deprecated, mostly cause all ports are already staged, and all new ports must be stagedir compliant. I had not removed it earlier are there are other keywords which need to change/remove/be added, and sometimes functionality (auto-assigner) can rely on or use/add keywords in certain cases, and may not resiliently handle their non-presence. I'll work with @gonzo to verify the latter is not the case, and remove it once that has been identified.
In the meantime, I've fixed the description link, added deprecated messaging to it's description, and will delete the redirected page (after seeing if any other pages in the wiki depend on it)
(In reply to Kubilay Kocak from comment #2) Needs staging is not used in auto-assigner, so it's safe to remove it.
(In reply to Oleksandr Tymoshenko from comment #4) Thanks. the auto assignment of keyword:patch based on [tags] in summary has now been removed iirc? Beyond that, are there additions/removals of any keywords in the AA code left at this stage?
Is there anything else we can do here?
Yep, need to test and confirm (needs-qa) whether global keyword removal cascades metadata removal from objects with that keyword.
*hitting upstream again to get confirmation from bugzilla 5.x codebase*
Upstream: justdave | Yes, it does. https://github.com/bugzilla/bugzilla/blob/5.2/Bugzilla/DB/Schema.pm#L600