Bug 252651 - Making math/suitesparse depend on onetbb
Summary: Making math/suitesparse depend on onetbb
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-fortran (Nobody)
Depends on:
Blocks: 252648 252785 252786 252788 252789 252790 252868 252870
  Show dependency treegraph
Reported: 2021-01-13 21:14 UTC by Ganael LAPLANCHE
Modified: 2021-01-20 21:43 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (fortran)
martymac: maintainer-feedback? (fortran)

Proposed patch to disable TBB option (1.02 KB, patch)
2021-01-16 14:26 UTC, Ganael LAPLANCHE
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer 2021-01-13 21:14:44 UTC

As a maintainer of math/suitesparse, could you have a look at PR #252648:


In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run:


and error logs:


c++ -O2 -pipe  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -O3 -fexceptions -fPIC -fopenmp -DHAVE_TBB   -I../../CHOLMOD/Include -I../../SuiteSparse_config -I../Include -c ../Source/spqr_parallel.cpp
../Source/spqr_parallel.cpp:10:10: fatal error: 'tbb/task_scheduler_init.h' file not found
#include <tbb/task_scheduler_init.h>
1 error generated.

Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ?

To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648.

Thanks for your contribution,
Best regards,

Comment 1 Ganael LAPLANCHE freebsd_committer 2021-01-16 14:26:43 UTC
Created attachment 221631 [details]
Proposed patch to disable TBB option
Comment 2 Ganael LAPLANCHE freebsd_committer 2021-01-16 14:27:33 UTC

We can disable TBB option while waiting for a proper patch (see attached patch).

Would that be acceptable ?

Comment 3 Thierry Thomas freebsd_committer 2021-01-16 16:16:00 UTC
I guess that this has an impact on performances, but this port is a suite of several different libraries, and this is difficult to evaluate.

Thus your patch seems acceptable if you do not commit it to early: please wait for the latest moment!
Comment 4 Ganael LAPLANCHE freebsd_committer 2021-01-16 18:59:14 UTC
Hi Thierry,

OK, thanks for your feedback. I'll commit it during the switch then.

Have a nice w-e,

Comment 5 Greg V 2021-01-19 12:58:06 UTC
Raised an issue upstream:

Comment 6 Ganael LAPLANCHE freebsd_committer 2021-01-19 15:07:27 UTC