Hello, As a maintainer of math/suitesparse, could you have a look at PR #252648: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648 In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run: http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-13_17h15m06s and error logs: http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-13_17h15m06s/logs/errors/suitesparse-5.8.1.log c++ -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -O3 -fexceptions -fPIC -fopenmp -DHAVE_TBB -I../../CHOLMOD/Include -I../../SuiteSparse_config -I../Include -c ../Source/spqr_parallel.cpp ../Source/spqr_parallel.cpp:10:10: fatal error: 'tbb/task_scheduler_init.h' file not found #include <tbb/task_scheduler_init.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ? To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648. Thanks for your contribution, Best regards, Ganael.
Created attachment 221631 [details] Proposed patch to disable TBB option
Hello, We can disable TBB option while waiting for a proper patch (see attached patch). Would that be acceptable ? Ganael.
I guess that this has an impact on performances, but this port is a suite of several different libraries, and this is difficult to evaluate. Thus your patch seems acceptable if you do not commit it to early: please wait for the latest moment!
Hi Thierry, OK, thanks for your feedback. I'll commit it during the switch then. Have a nice w-e, Ganael.
Raised an issue upstream: https://github.com/DrTimothyAldenDavis/SuiteSparse/issues/72
Thanks!
A commit references this bug: Author: martymac Date: Fri Feb 19 15:14:55 UTC 2021 New revision: 566074 URL: https://svnweb.freebsd.org/changeset/ports/566074 Log: Introduce devel/onetbb and mark devel/tbb as legacy Intel oneAPI tbb 2021.1 (onetbb) has been released[1][2] and has deprecated several interfaces over tbb 2020, breaking most dependent ports. Old tbb 2020 will be kept for a certain time to allow transition but will be removed in a near future as it CONFLICTS with devel/onetbb. New ports should now use devel/onetbb instead of devel/tbb. We tried to move a maximum number of dependent ports to devel/onetbb (or disable dependency when not possible), but some of them still remain stuck to devel/tbb. Remaining ones have not been identified as major dependencies themselves and will be fixed as soon as updates are available from upstream. PR: 252648, 252688 [3], 252683 [4], 252651 [5], 252690 [3], 252693 [3], 252695 [3], 252696 [3], 252786 [3], 252649, 252868 [6], 252870 [5], 252684 [7], 252785 [7] Approved by: yuri [3], jwb [4], thierry [5], FreeBSD@Shaneware.biz [6], maintainer timeout [7] [1] https://software.intel.com/content/www/us/en/develop/articles/intel-oneapi-threading-building-blocks-release-notes.html [2] https://software.intel.com/content/www/us/en/develop/articles/tbb-revamp.html Changes: head/archivers/par2cmdline-tbb/Makefile head/biology/bowtie2/Makefile head/cad/opencascade/Makefile head/devel/Makefile head/devel/onetbb/ head/devel/onetbb/Makefile head/devel/onetbb/distinfo head/devel/onetbb/files/ head/devel/onetbb/files/onetbb.pc.in head/devel/onetbb/files/patch-src-tbbbind-CMakeLists.txt head/devel/onetbb/files/patch-test-common-memory_usage.h head/devel/onetbb/files/patch-test-tbbmalloc-test_malloc_compliance.cpp head/devel/onetbb/pkg-descr head/devel/onetbb/pkg-plist head/devel/tbb/Makefile head/devel/tbb/pkg-descr head/graphics/blender/Makefile head/graphics/blender/Makefile.options head/graphics/blender/files/patch-intern_cycles_device_device__cpu.cpp head/graphics/blender/files/patch-intern_cycles_util_util__task.cpp head/graphics/blender/files/patch-intern_cycles_util_util__task.h head/graphics/blender/files/patch-intern_cycles_util_util__tbb.h head/graphics/blender/files/patch-source_blender_blenlib_BLI__index__range.hh head/graphics/blender/files/patch-source_blender_blenlib_BLI__task.h head/graphics/blender/files/patch-source_blender_blenlib_intern_task__pool.cc head/graphics/embree/Makefile head/graphics/oidn/Makefile head/graphics/opencv/Makefile head/graphics/openimageio/Makefile head/math/dune-common/Makefile head/math/dune-geometry/Makefile head/math/dune-grid/Makefile head/math/dune-pdelab/Makefile head/math/dune-uggrid/Makefile head/math/openturns/Makefile head/math/saga/Makefile head/math/suitesparse/Makefile head/misc/ngraph/Makefile
Fixed in the draft SuiteSparse v5.11.0 (TBB is removed). See https://github.com/DrTimothyAldenDavis/SuiteSparse/issues/72#issuecomment-1065706830. Waiting for the release.
Great! Thanks for the update Thierry!