Hello, As a maintainer of www/osrm-backend, could you have a look at PR #252648: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648 In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run: http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-17_09h08m36s and error logs: http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-17_09h08m36s/logs/errors/osrm-backend-5.23.0.log ERROR: Intel TBB NOT found! -- Looked for Threading Building Blocks in /usr CMake Error at cmake/FindTBB.cmake:274 (message): Could NOT find TBB library. Call Stack (most recent call first): CMakeLists.txt:527 (find_package) Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ? To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648. You will also need suitesparse patches from PR #252651 as suitesparse does not build with oneTbb. Thanks for your contribution, Best regards, Ganael.
Created attachment 222210 [details] Patch to make www/osrm-backend build with devel/onetbb
Hi, The attached patch makes www/osrm-backend build with devel/onetbb. I also updated the port to its latest version as that version was released while I worked on the patch. Build tested on FreeBSD 12.2 using Poudriere. All the best, Peter.
Hello Peter, Thanks a lot for your feedback. As discussed in private, feel free look for help upstream, developers from the project may help you supporting oneTbb and validate your patch. Meanwhile, I have found several minor things that may be worth to fix : 1) In patch-cmake_FindTBB.cmake: set (TBB_INC_SEARCH_DIR /usr/local/include/oneapi) Could you avoid hard-coding that path and use ${_TBB_INSTALL_DIR} ? 2) Portlint gives : WARN: Makefile: [31]: use a tab (not space) after a variable name 3) Pkg-plist2 has been left :) 4) (as a side note) I also found a hardcoded path (/usr/local) in files/osrm.in. Could you use LOCALBASE here too ? Could you have a look at that ? Also, if you want to update to a newer version before the switch to onetbb, you can file another PR, I'll take care of it :) Best regards, Ganael.
Created attachment 222363 [details] Patch to make www/osrm-backend build with devel/onetbb (updated) Updated version of initial patch proposal
Hello Peter, I have updated your initial patch after update to 5.24.0 in ports. Could you try to check with upstream developers what they think about that patch ? Thanks in advance! Best regards, Ganael.
Hello Peter, oneTbb seems to be officially supported since version 5.27.0 (see commit 91895604c9). Could you update www/osrm-backend with a newer version ? Cheers, Ganael.