Bug 252790 - Making www/osrm-backend depend on onetbb
Summary: Making www/osrm-backend depend on onetbb
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on: 252651 253348
Blocks: 252648
  Show dependency treegraph
 
Reported: 2021-01-17 19:31 UTC by Ganael LAPLANCHE
Modified: 2024-11-08 11:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)
martymac: maintainer-feedback? (freebsd)


Attachments
Patch to make www/osrm-backend build with devel/onetbb (25.45 KB, patch)
2021-02-06 12:24 UTC, Peter Laursen
no flags Details | Diff
Patch to make www/osrm-backend build with devel/onetbb (updated) (21.90 KB, patch)
2021-02-11 11:40 UTC, Ganael LAPLANCHE
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-01-17 19:31:43 UTC
Hello,

As a maintainer of www/osrm-backend, could you have a look at PR #252648:

  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=252648

In short, TBB version 2021 will soon be available as devel/onetbb but the port you maintain does not build correctly with it, see the following Poudriere run:

  http://box.martymac.org/FreeBSD-Packages/build.html?mastername=FBSD122amd64-tbb-migr&build=2021-01-17_09h08m36s

and error logs:

http://box.martymac.org/FreeBSD-Packages/data/FBSD122amd64-tbb-migr/2021-01-17_09h08m36s/logs/errors/osrm-backend-5.23.0.log

ERROR: Intel TBB NOT found!
-- Looked for Threading Building Blocks in /usr
CMake Error at cmake/FindTBB.cmake:274 (message):
  Could NOT find TBB library.
Call Stack (most recent call first):
  CMakeLists.txt:527 (find_package)

Could you try to provide a patch (important: *by replying to this PR*) to facilitate the migration to devel/onetbb ?

To help you modifying your port, expected patches to devel/tbb and devel/onetbb are available in PR #252648.

You will also need suitesparse patches from PR #252651 as suitesparse does not build with oneTbb.

Thanks for your contribution,
Best regards,

Ganael.
Comment 1 Peter Laursen 2021-02-06 12:24:06 UTC
Created attachment 222210 [details]
Patch to make www/osrm-backend build with devel/onetbb
Comment 2 Peter Laursen 2021-02-06 12:27:25 UTC
Hi,
The attached patch makes www/osrm-backend build with devel/onetbb.
I also updated the port to its latest version as that version was released while I worked on the patch.

Build tested on FreeBSD 12.2 using Poudriere.

All the best,

Peter.
Comment 3 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-02-08 11:16:39 UTC
Hello Peter,

Thanks a lot for your feedback.

As discussed in private, feel free look for help upstream, developers from the project may help you supporting oneTbb and validate your patch.

Meanwhile, I have found several minor things that may be worth to fix :

1) In patch-cmake_FindTBB.cmake:

set (TBB_INC_SEARCH_DIR /usr/local/include/oneapi)

Could you avoid hard-coding that path and use ${_TBB_INSTALL_DIR} ?

2) Portlint gives :

WARN: Makefile: [31]: use a tab (not space) after a variable name

3) Pkg-plist2 has been left :)

4) (as a side note) I also found a hardcoded path (/usr/local) in files/osrm.in. Could you use LOCALBASE here too ?

Could you have a look at that ?

Also, if you want to update to a newer version before the switch to onetbb, you can file another PR, I'll take care of it :)

Best regards,

Ganael.
Comment 4 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-02-11 11:40:21 UTC
Created attachment 222363 [details]
Patch to make www/osrm-backend build with devel/onetbb (updated)

Updated version of initial patch proposal
Comment 5 Ganael LAPLANCHE freebsd_committer freebsd_triage 2021-02-11 11:42:24 UTC
Hello Peter,

I have updated your initial patch after update to 5.24.0 in ports.

Could you try to check with upstream developers what they think about that patch ?

Thanks in advance!

Best regards,

Ganael.
Comment 6 Ganael LAPLANCHE freebsd_committer freebsd_triage 2023-03-01 15:03:42 UTC
Hello Peter,

oneTbb seems to be officially supported since version 5.27.0 (see commit 91895604c9).

Could you update www/osrm-backend with a newer version ?

Cheers,

Ganael.
Comment 7 Peter Laursen 2024-11-05 23:04:21 UTC
Hi,
This bug has recently been overtaken by events. The latest version (updated by me recently) now depends on onetbb.
I'm preparing an update to the latest Git commit version.
This bug can safely be closed.

All the best,

Peter.
P.S.: It's a little difficult to figure out what flags to set.
Comment 8 Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-11-08 11:21:55 UTC
Hello Peter,

Thanks for the update, I'll close that bug report then.

Best regards,

Ganael.