Bug 280557 (unbundled_samba419_by_default) - net/samba419: Switch to building without bundled dependencies by default
Summary: net/samba419: Switch to building without bundled dependencies by default
Status: Closed FIXED
Alias: unbundled_samba419_by_default
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on: 280510
Blocks: 276988 277381 278813 279401 samba419_freeradius3_conflict 280774
  Show dependency tree / graph
 
Reported: 2024-08-01 14:54 UTC by Mateusz Piotrowski
Modified: 2024-08-16 19:47 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mikael)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-01 14:54:23 UTC 
Building Samba with bundled dependencies for ldb, talloc, tdb, etc. is nice and easy, but leads to many conflicts in the ports tree. For example, Samba installs its internal version of talloc in the same place as the devel/talloc port, which makes it impossible to install programs like Freeradius3.

I propose that we transition to building Samba without bundled dependencies by default.
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2024-08-01 14:55:51 UTC 
Feel free to patch it.
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-01 15:13:42 UTC 
(In reply to Mikael Urankar from comment #1)
Thanks! I will once I get the dependencies committed.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-08-11 18:25:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a852ac5ac035572f7639fe3c2b76bb8078003c8e

commit a852ac5ac035572f7639fe3c2b76bb8078003c8e
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-08-11 18:20:28 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-08-11 18:24:57 +0000

    net/samba419: Allow setting *_BUNDLED_* via make.conf

    PR:             280557
    Approved by:    portmgr blanket

 net/samba419/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-08-16 19:45:13 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e75af545d1d1c258ce8135c422d62f35235ee0fc

commit e75af545d1d1c258ce8135c422d62f35235ee0fc
Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
AuthorDate: 2024-08-16 19:34:41 +0000
Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
CommitDate: 2024-08-16 19:44:10 +0000

    net/samba419: Use external dependencies by default

    The Samba package can be built with the following dependencies bundled
    in: cmocka, talloc, tevent, tdb, and ldb. This is a handy way of getting
    the right versions of all those dependencies. Unfortunately, the bundled
    dependencies conflict with their packaged counterparts, which leads to
    the build and installation issues with packages like security/sssd2 and
    net/freeradius3. Building Samba without the bundled dependencies
    resolves those issues, so let's do that.

    PR:             280557
    Approved by:    samba (mikael, 0mp)
    Sponsored by:   Klara, Inc.

 net/samba419/Makefile | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Comment 5 Mateusz Piotrowski freebsd_committer freebsd_triage 2024-08-16 19:47:59 UTC 
Samba 4.19 is now built without the bundled dependencies by default. It should resolve a lot of issues caused by package conflicts.