Bug 216218
Created attachment 179047 [details]
fix bogus pointer comparison
Comment on attachment 179047 [details] fix bogus pointer comparison Builds fine with the patch: http://sprunge.us/MDHM A commit references this bug: Author: tcberner Date: Fri Jan 20 12:45:04 UTC 2017 New revision: 431952 URL: https://svnweb.freebsd.org/changeset/ports/431952 Log: Fix ruby-qtruby with newer clang Clang 4.0 trips on the bogus pointer comparison. As the produced code may change, bump PORTREVISION. PR: 216218 Reported by: jbeich Approved by: rakuco (mentor) Changes: head/devel/ruby-qtruby/Makefile head/devel/ruby-qtruby/files/patch-src_qtruby.cpp (In reply to commit-hook from comment #3) Can you MFH it into 2017Q1? This can probably use "Approved by: ports-secteam blanket" since the existing behavior doesn't change. https://wiki.freebsd.org/ports-secteam#Blanket_Approval A commit references this bug: Author: tcberner Date: Sat Jan 21 12:16:01 UTC 2017 New revision: 432025 URL: https://svnweb.freebsd.org/changeset/ports/432025 Log: MFH: r431952 Fix ruby-qtruby with newer clang Clang 4.0 trips on the bogus pointer comparison. As the produced code may change, bump PORTREVISION. PR: 216218 Reported by: jbeich Approved by: rakuco (mentor) PR: 216218 Approved by: ports-secteam (junovitch), rakuco (mentor) Changes: _U branches/2017Q1/ branches/2017Q1/devel/ruby-qtruby/Makefile branches/2017Q1/devel/ruby-qtruby/files/patch-src_qtruby.cpp A commit references this bug: Author: tcberner Date: Sat Jan 21 12:16:01 UTC 2017 New revision: 432025 URL: https://svnweb.freebsd.org/changeset/ports/432025 Log: MFH: r431952 Fix ruby-qtruby with newer clang Clang 4.0 trips on the bogus pointer comparison. As the produced code may change, bump PORTREVISION. PR: 216218 Reported by: jbeich Approved by: rakuco (mentor) PR: 216218 Approved by: ports-secteam (junovitch), rakuco (mentor) Changes: _U branches/2017Q1/ branches/2017Q1/devel/ruby-qtruby/Makefile branches/2017Q1/devel/ruby-qtruby/files/patch-src_qtruby.cpp |
src/qtruby.cpp:2097:17: error: ordered comparison between pointer and zero ('void *' and 'int') return (ptr > 0 ? Qtrue : Qfalse); ~~~ ^ ~ build log: http://sprunge.us/CCYd regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3