Bug 216216 - graphics/swftools: fails to build with clang 4.0
Summary: graphics/swftools: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency treegraph
 
Reported: 2017-01-18 08:34 UTC by Jan Beich
Modified: 2017-01-31 00:04 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dinoex)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-01-18 08:34:35 UTC
xpdf/GlobalParams.cc:925:12: error: ordered comparison between pointer and zero ('char *' and 'int')
    if(pos1>=0)
       ~~~~^ ~
xpdf/GlobalParams.cc:927:17: error: ordered comparison between pointer and zero ('char *' and 'int')
    else if(pos2>=0)
            ~~~~^ ~

build log: http://sprunge.us/PZcf
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer 2017-01-21 16:11:34 UTC
A commit references this bug:

Author: dinoex
Date: Sat Jan 21 16:11:02 UTC 2017
New revision: 432055
URL: https://svnweb.freebsd.org/changeset/ports/432055

Log:
  - fix build with clang4
  PR:		216216

Changes:
  head/graphics/swftools/Makefile
  head/graphics/swftools/files/patch-GlobalParams.cc
Comment 2 Jan Beich freebsd_committer 2017-01-21 22:22:38 UTC
Can you request MFH to 2017Q1 or maybe use "ports-secteam blanket"?

I confirm the fix was enough to unbreak /projects/clang400-import@312309 i386: http://sprunge.us/DWKD