Bug 216629 - games/cake: fails to build with clang 4.0
Summary: games/cake: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-30 23:09 UTC by Jan Beich
Modified: 2017-03-06 08:52 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-30 23:09:09 UTC 
cake/q3bsp.cpp:2852:62: error: ordered comparison between pointer and zero ('int *' and 'int')
      if (face->facetype != FACETYPE_PATCH || face->numverts <= 0) continue;
                                              ~~~~~~~~~~~~~~ ^  ~

http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/cake-2005.12.26_10.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-06 08:51:51 UTC 
A commit references this bug:

Author: danfe
Date: Mon Mar  6 08:51:07 UTC 2017
New revision: 435522
URL: https://svnweb.freebsd.org/changeset/ports/435522

Log:
  Unbreak the build against Clang 4.0.

  PR:	216629

Changes:
  head/games/cake/Makefile
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2017-03-06 08:52:48 UTC 
Should be fixed as of ports r435522.