Bug 216227
Created attachment 179361 [details]
devel/godot maintainer update
Update devel/godot to 2.1.2, the failing code has been updated in this release.
Use of external projects that have been bundled with this project are starting to be changed. freetype and png should either both be external or both internal as mixing leads to issues. After code shuffling the internal copy of musepack and speex fail to work and adding them as external dependencies is just easier than fixing it, I think these are also planned to be used as external libs in future releases. This all leads to more changes than expected in a minor point release.
A commit references this bug: Author: jbeich Date: Sat Jan 28 18:33:12 UTC 2017 New revision: 432641 URL: https://svnweb.freebsd.org/changeset/ports/432641 Log: devel/godot: update to 2.1.2 Changes: https://godotengine.org/article/maintenance-release-godot-2-1-1 Changes: https://godotengine.org/article/maintenance-release-godot-2-1-2 PR: 216227 Submitted by: Shane <FreeBSD@ShaneWare.Biz> (maintainer) Changes: head/devel/godot/Makefile head/devel/godot/distinfo head/devel/godot/files/patch-SConstruct head/devel/godot/files/patch-drivers_SCsub head/devel/godot/files/patch-drivers_rtaudio_RtAudio.cpp head/devel/godot/files/patch-drivers_rtaudio_RtAudio.h head/devel/godot/files/patch-main_main.cpp head/devel/godot/files/patch-modules_speex_audio__stream__speex.cpp head/devel/godot/files/patch-platform_x11_detect.py head/devel/godot/files/patch-thirdparty_rtaudio_RtAudio.cpp head/devel/godot/files/patch-thirdparty_rtaudio_RtAudio.h Thanks. Landed. Confirmed green build with Clang 4.0: http://package18.nyi.freebsd.org/data/headi386PR216008-default/2017-01-30_10h29m15s/logs/godot-2.1.2.log For anyone using this as reference - the relevant godot commit is https://github.com/godotengine/godot/commit/31f929caa2 the code change was - if (pointer > 0) + if (pointer != NULL) In sys/_null.h NULL gets defined as nullptr which is defined in c++/v1/__nullptr |
scene/gui/tree.cpp:1295:27: error: ordered comparison between pointer and zero ('TreeItem *' and 'int') if (c->get_children() > 0) ~~~~~~~~~~~~~~~~~ ^ ~ build log: http://sprunge.us/AVWL (interleaved due to ALLOW_MAKE_JOBS) regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3