Bug 216630

Summary:	games/bloboats: fails to build with clang 4.0
Product:	Ports & Packages	Reporter:	Jan Beich <jbeich>
Component:	Individual Port(s)	Assignee:	Emanuel Haupt <ehaupt>
Status:	Closed FIXED
Severity:	Affects Only Me	Keywords:	needs-patch
Priority:	---	Flags:	bugzilla: maintainer-feedback? (ehaupt)
Version:	Latest
Hardware:	Any
OS:	Any
See Also:	https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216075 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216074 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216072 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216016 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215861 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216015 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216046 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216051 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216052 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216056 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216058 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216019 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216159 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216176 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216194 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216197 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216198 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216200 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216203 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216206 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216211 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216213 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216214 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216215 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216216 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216217 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216218 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216221 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216222 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216227 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216228 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216632 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216629 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216631 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216233 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216234 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216235 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216253 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216354 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216355 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216356 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216357 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216358 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216076 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216615 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216617 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216618 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216619 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216620 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216621 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216622 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216623 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216624 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216626 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216627 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216633 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216634 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216635 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216636 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216637 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216638 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216639 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216640 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216641 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216642
Bug Depends on:
Bug Blocks:	216008

Description Jan Beich freebsd_committer

2017-01-30 23:15:07 UTC

src/menu.cpp:1570:11: error: ordered comparison between pointer and zero ('SDL_Rect **' and 'int')
        if(modes > 0) {
           ~~~~~ ^ ~

build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/bloboats-1.0.2_6.log
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3

Comment 1 Jan Beich freebsd_committer

2017-02-02 09:54:16 UTC

Note, the error isn't new. GCC (even 4.2) can show it as well.

$ pkg install gcc5
$ make clean all CC='gcc5 -Werror=extra' CXX='g++5 -Werror=extra' CPP=cpp5 CHOSEN_COMPILER_TYPE=gcc BATCH=
[...]
src/menu.cpp: In member function 'void menu::resolution()':
src/menu.cpp:1570:13: error: ordered comparison of pointer with integer zero [-Werror=extra]
  if(modes > 0) {
             ^

Comment 2 commit-hook freebsd_committer

2017-02-03 12:36:36 UTC

A commit references this bug:

Author: ehaupt
Date: Fri Feb  3 12:35:52 UTC 2017
New revision: 433222
URL: https://svnweb.freebsd.org/changeset/ports/433222

Log:
  Fix build with clang 4.0

  PR:		216630 (based on)
  Notified by:	jbeich

Changes:
  head/games/bloboats/Makefile
  head/games/bloboats/files/patch-Makefile
  head/games/bloboats/files/patch-src_menu.cpp