Bug 216634
Created attachment 181537 [details]
patch for files/
Here is the fix.
There's an upstream fix for this: https://github.com/Kitware/VTK/commit/33631146a85dfa64433c3997f166cbaa96bedee9.patch Sorry to see this bug has languished for so long. I'm a new committer and will take this on as soon as my bugtracker account is updated. In the meantime, can you update the patch set? This fix alone does not appear to be sufficient anymore. I'm seeing additional build errors on 11.1-RELEASE. Created attachment 188723 [details]
Unified diff
This patch set fixes the build on 11.1-RELEASE.
It would probably be better to fix the MSCPP_EXTRA definition rather than simply remove it, but this is a step forward.
Also added a couple improvements based on port check messages.
A commit references this bug: Author: jwb Date: Wed Dec 13 03:34:37 UTC 2017 New revision: 456189 URL: https://svnweb.freebsd.org/changeset/ports/456189 Log: science/paraview: Unbreak build with clang 4.0 PR: 216634 Submitted by: Jan Beich Approved by: jrm (mentor), maintainer timeout (3.5 months) Differential Revision: https://reviews.freebsd.org/D13462 Changes: head/science/paraview/Makefile head/science/paraview/files/patch-Plugins_CDIReader_cdilib.c head/science/paraview/files/patch-VTK_ThirdParty_netcdf_vtknetcdf_cxx_ncvalues.h head/science/paraview/files/patch-VTK_ThirdParty_netcdf_vtknetcdf_cxx_netcdfcpp.h head/science/paraview/files/patch-VTK_ThirdParty_xdmf2_vtkxdmf2_libsrc_XdmfDsmComm.cxx Forgotten to close? I confirm, the port builds fine with Clang 4.0. http://beefy9.nyi.freebsd.org/data/latest-per-pkg/paraview/5.2.0_3/111amd64-default.log http://beefy10.nyi.freebsd.org/data/latest-per-pkg/paraview/5.2.0_3/111i386-default.log |
VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfDsmComm.cxx:55:18: error: ordered comparison between pointer and zero ('void *' and 'int') if(Msg->Data <= 0 ){ ~~~~~~~~~ ^ ~ VTK/ThirdParty/xdmf2/vtkxdmf2/libsrc/XdmfDsmComm.cxx:69:18: error: ordered comparison between pointer and zero ('void *' and 'int') if(Msg->Data <= 0 ){ ~~~~~~~~~ ^ ~ build log: http://package18.nyi.freebsd.org/data/headamd64PR216008-default/2017-01-29_16h09m05s/logs/errors/paraview-5.2.0.log regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3